galaxyproject / pulsar

Distributed job execution application built for Galaxy
https://pulsar.readthedocs.io
Apache License 2.0
37 stars 50 forks source link

Fix loading the Galaxy dependency resolvers config, plus additional config directory fixes #256

Closed natefoo closed 3 years ago

natefoo commented 3 years ago

Updates to galaxy imports a while back broke loading the dependency resolvers config file (when using galaxy-tool-util instead of galaxy-lib).

Changes:

I also tested that you can set the resolvers under dependency_resolution.resolvers like so in app.yml:

dependency_resoution:
  resolvers:
    - type: conda
      auto_init: false
      auto_install: true
      prefix: /path/to/conda

This should(?) probably be the preferred method going forward once we update documentation. This also works under the galaxy key of galaxy.yml in Galaxy.

Relatedly, the behavior here also looks wrong, it shouldn't be returning job_metrics from the kwargs if passed in. But I think galaxy.job_metrics:JobMetrics doesn't load config from a dict yet anyway.