search

galaxyproject / pulsar

Distributed job execution application built for Galaxy
https://pulsar.readthedocs.io
Apache License 2.0
37 stars 50 forks source link

If `manager` is specified in the app conf and --manager is supplied, make the single manager have the supplied name #314

Closed natefoo closed 1 year ago

natefoo commented 1 year ago

Potentially fixes #313 but I haven't actually fully tested it, just verified that it resolves the exception. And it's not my favorite. @jmchilton?

jmchilton commented 1 year ago

None of the tests override this name. Is there a reason you cannot just use the default manage name? Oh... is it a message queue thing?

jmchilton commented 1 year ago

I feel like the whole approach might be mistaken though... the problem is different destinations are using the same amqp queue names? I kind of the think of the manager in the coexecution scenario as named default and as the only manager - it isn't immediately clear why anyone would want to change that. Would the better approach here be to just key those on a different parameter?

mvdbeek commented 1 year ago

I think this was superseded by https://github.com/galaxyproject/pulsar/issues/313#issuecomment-1424686260