search

galaxyproject / pulsar

Distributed job execution application built for Galaxy
https://pulsar.readthedocs.io
Apache License 2.0
37 stars 49 forks source link

Do not attempt to complete pre- or post-process if jobs are cancelled in the middle of either stage #365

Closed natefoo closed 2 months ago

natefoo commented 2 months ago

Mostly fixes #364. Ideally we would also interrupt any running transfers since those could be exceptionally long running and wasteful, but doing so requires interrupting a thread running a non-looping action.

We are probably better off moving those to more properly managed asynchronous tasks (celery, multiprocessing, etc.).

EDIT: Also fixes #353, although not by caring whether it's a 403.

mvdbeek commented 2 months ago

Thanks @natefoo, should I cut a new release ?

natefoo commented 2 months ago

No, I'm deploying from git to JS2 right now, and will have more things coming. THanks!