galaxyproject / tools-devteam

Contains a set of Galaxy Tools mostly written by the Galaxy Team.
36 stars 92 forks source link

gi2taxonomy seems outdated #483

Open bernt-matthias opened 7 years ago

bernt-matthias commented 7 years ago

The tool depends on package_taxonomy_1_0_0 which seems to be replaced by data_manager_fetch_ncbi_taxonomy.

Furthermore the data for the tool data is hard coded in the python file: see GI2TAX, NAME_FILE, NODE_FILE. It would be nice if

This would be nice because the tool could then map arbitrary IDs (e.g. uniprot ids) to the taxonomy, given a mapping from the IDs to NCBI taxids.

One could also thing about to simplify the tool such that it creates the table only from the taxids and the mapping from the gi (or other ids) could be done with other tools (e.g. join).

bgruening commented 7 years ago

The package_* should be replaced by a Conda package. It is compiling some C program. The data_manager is there to retrieve data sued by the compiled tool. That said the mentioned improvements are much needed!

bernt-matthias commented 7 years ago

OK. I would prefer to extend the ete package instead (https://toolshed.g2.bx.psu.edu/view/earlhaminst/ete/a4ba317fc713). The API has the same funtionality -- and can even search for names and taxids. I will try to do this these days. I just have two questions:

bernt-matthias commented 7 years ago

I just started: see here: https://github.com/TGAC/earlham-galaxytools/pull/90