allow larger number of columns for column maker

galaxyproject / tools-devteam

Contains a set of Galaxy Tools mostly written by the Galaxy Team.

36 stars 92 forks source link

allow larger number of columns for column maker #577

Closed bernt-matthias closed 3 years ago

bernt-matthias commented 4 years ago

fixes https://github.com/galaxyproject/tools-devteam/issues/505

idea:

use inputs config file
inject metadata (unfortunatelly that is not in the jsonfile)
overwrite command line arguments (switched to argparse) using json

bernt-matthias commented 3 years ago

@hexylena what is your take on https://github.com/galaxyproject/tools-devteam/pull/577#discussion_r497374267

hexylena commented 3 years ago

It could be nice but, isn't the devteam tools policy more or less "maintenance mode" and not making big changes like refactoring python version which might introduce differences, instead only fixing bugs? (Or did I get the wrong impression from somewhere)

bernt-matthias commented 3 years ago

I can easily drop the py2to3 commit .. what do you think @bgruening

bernt-matthias commented 3 years ago

@hexylena .. I accidentally removed your commit (647bdd7) simplifying the json parsing. Could you restore it?

bernt-matthias commented 3 years ago

Can we merge this?

bgruening commented 3 years ago

This looks great to me. Thanks @bernt-matthias! Ready?

bernt-matthias commented 3 years ago

This looks great to me. Thanks @bernt-matthias! Ready?

sure

bgruening commented 3 years ago

Merci!