search

galaxyproject / tools-devteam

Contains a set of Galaxy Tools mostly written by the Galaxy Team.
37 stars 92 forks source link

Fix Python2-only syntax in sicer tool #580

Closed nsoranzo closed 3 years ago

nsoranzo commented 3 years ago

Fix:

    except Exception, e:
                    ^
SyntaxError: invalid syntax

Also cleanup wrapper and script.

nsoranzo commented 3 years ago

sicer works fine on 20.05, but biocontainers dependency resolution is broken on 20.09 by https://github.com/galaxyproject/galaxy/commit/f0a55a399cf96cd8c11e3ab8a0d283e9df852088 because the keys in mulled_resolution_cache are lowercase while the requirement name is uppercase.

drosofff commented 3 years ago

Hi @nsoranzo Many thanks for the Python 3 conversion !

I think that the macro.xml file is missing in the repo as well as an import statement in the xml wrapper

drosofff commented 3 years ago

Hoops forget it @nsoranzo my bad