search

galaxyproject / tools-devteam

Contains a set of Galaxy Tools mostly written by the Galaxy Team.
37 stars 92 forks source link

Allow "Compute an expression on every row" to succeed with empty input #585

Closed wm75 closed 3 years ago

wm75 commented 3 years ago

Currently the tool fails when its input doesn't have at least one line of content, which is a nuisance with more complex WFs and collections.

While working on this I tried to improve the tool in a few other ways, too.

wm75 commented 3 years ago

Ah, of course, you're right. This whole wrapper/json/python dance is confusing.

nsoranzo commented 3 years ago

I just noticed that column_maker was migrated to tools-iuc in https://github.com/galaxyproject/tools-iuc/pull/2469 , not sure why it wasn't removed from here!

@wm75 Would you be interested in merging it again into tools-iuc and remove it from here for good?

wm75 commented 3 years ago

Yes, just read @jmchilton's https://github.com/galaxyproject/tools-iuc/issues/3494. I can do this tonight.

nsoranzo commented 3 years ago

@wm75 Thanks! I realise the 2 have diverged significantly, so let me know if you'd like help or change your mind!

jmchilton commented 3 years ago

Thanks so much!

wm75 commented 3 years ago

@nsoranzo @jmchilton @mvdbeek addressed by #586. Turned out the merge is not that complicated this way round. After merging the new PR the tools-devteam version can finally be removed and the new version moved over to tools-iuc (will produce a rather ugly diff over there, but the tools-iuc version was just too far behind).