galaxyproject / tools-devteam

Contains a set of Galaxy Tools mostly written by the Galaxy Team.
37 stars 92 forks source link

Python 2 print statement in older tool -- could be more #604

Closed jennaj closed 2 years ago

jennaj commented 2 years ago

Fix or deprecate/remove?

nsoranzo commented 2 years ago

@jennaj This should be pretty easy to fix, if that's a tool that people still use. Just let me know what's the preferred option between fix and deprecate.

jennaj commented 2 years ago

Hi @nsoranzo

Fixing it seems best if not too much trouble. Removing older tools always carries a risk of disappointing someone, or breaking an older workflow still out in the wild.

@bgruening did some magic to make it work at the EU server. Guessing it involved fixing up that print statement to be Py3 compatible, in their version (don't see any changes in the dev repo or toolshed).

If you could reference this issue in the PR, or post the PR back here, that would help link all together to make sure the update makes it out to the ORG server and into the 22.01 release (this tool is included as a default -- I think but can confirm)

Thank you!

bgruening commented 2 years ago

I really just changed the print statements - there have been 2.