search

galaxyproject / tools-iuc

Tool Shed repositories maintained by the Intergalactic Utilities Commission
https://galaxyproject.org/iuc
MIT License
162 stars 436 forks source link

Trim whitespace on the accession input filed #4439

Open afgane opened 2 years ago

afgane commented 2 years ago

Describe the bug Leaving a trailing whitespace on the Download and Extract Reads in FASTA/Q format from NCBI SRA tool leads to a failed job with error message unary operator expected, which is not indicative of the issue. Same accession without the trailing whitespace works fine.

Galaxy Version and/or server at which you observed the bug Galaxy Version: 22.01; usegalaxy.org

To Reproduce Steps to reproduce the behavior:

  1. Open tool form for tool Download and Extract Reads in FASTA/Q format from NCBI SRA
  2. Enter accession SRR18157861 (note the trailing whitespace)
  3. Job fails with ...tool_script.sh: line 61: [: SRR18157861: unary operator expected

Screenshots image

mvdbeek commented 2 years ago

That's a tool bug, I've transfered this to the iuc