Open peterjc opened 1 year ago
I think this should be moved to https://github.com/galaxyproject/galaxy-tool-repository-template , but I don't have write access to that repo.
Thanks for writing this up @peterjc .. Should be trivial to implement
@nsoranzo I think the main repo for developing the workflows will be the IUC repo. In particular once https://github.com/galaxyproject/tools-iuc/pull/4830 is done and merged ;)
So in the short term if this supported in principle, would a pull request go to https://github.com/galaxyproject/galaxy-tool-repository-template then?
@peterjc I would open a PR against IUC
Currently the GitHub actions template https://github.com/galaxyproject/tools-iuc/blob/master/.github/workflows/pr.yaml uses:
This is run in conjunction with a flake8 configuration under https://github.com/galaxyproject/tools-iuc/blob/master/setup.cfg
The individual tool authors using the template may wish to use different flake8 plugins (which may have specific version requirements). The suggestion from @bernt-matthias in discussion on https://github.com/peterjc/galaxy_blast/pull/149 is to add a
.flake_requirements
(orflake8_requirements
?).This could by default be just:
There are pros-and-cons to pinning this to current latest versions (it would avoid the dependencies changing without warning and introducing new checks, and thus breaking the CI unexpectedly, but complicates updating the CI checks):
Either way, the
pr.yaml
would become:Note this allows the tool author to remove
flake8-import-order
if they really wanted to.The tool authors can supplement the provided flake8 configuration for any additional plugins they add.