search

galaxyproject / tools-iuc

Tool Shed repositories maintained by the Intergalactic Utilities Commission
https://galaxyproject.org/iuc
MIT License
161 stars 421 forks source link

Bug in ampvis2 tax_show #6126

Open paulzierep opened 3 months ago

paulzierep commented 3 months ago

There is a bug in ampvis2 that brakes the wrapper if specific taxa should be shown.

It errors with:

Error: unexpected symbol in:
"    
                showRemainingTaxa"
Execution halted

I think the fix needs to be applied here: https://github.com/galaxyproject/tools-iuc/blob/d7cada7ddf775e946e218fdc839e6e4c8aac6d80/tools/ampvis2/macros.xml#L90 - need to check how to format the string correctly.

#set tax_show_list='c("' + '", "'.join(str($tax_show_cond.tax_show).split(",")) + '")'
paulzierep commented 3 months ago

ping @bernt-matthias maybe you are faster then me

bernt-matthias commented 3 months ago

Can you open a PR with add a test case?