search

galaxyproject / tools-iuc

Tool Shed repositories maintained by the Intergalactic Utilities Commission
https://galaxyproject.org/iuc
MIT License
163 stars 437 forks source link

bcftools_consensus has duplicate mask options #6546

Open pvanheus opened 1 week ago

pvanheus commented 1 week ago

The bcftools_consensus wrapper currently has two inputs for the --mask argument:

  1. https://github.com/galaxyproject/tools-iuc/blob/main/tools/bcftools/bcftools_consensus.xml#L77 - which is a simple boolean
  2. https://github.com/galaxyproject/tools-iuc/blob/main/tools/bcftools/bcftools_consensus.xml#L101 - which allows specifying the mask character and is currently unused.

I have created a fix for this (https://github.com/pvanheus/tools-iuc/blob/fix_duplicate_mask/tools/bcftools/bcftools_consensus.xml) but see that https://github.com/galaxyproject/tools-iuc/pull/6293 is currently open, so my fix should probably be applied on top of (a passing version of) that. I might find time to merge into that PR but in the meantime leaving this issue here as a reminder.