galaxyproject / training-material

A collection of Galaxy-related training material
https://training.galaxyproject.org
MIT License
294 stars 846 forks source link

Proteome annotation tuto with ProteoRE #1413

Closed combesf closed 4 years ago

combesf commented 4 years ago

pull request by Flo tu be pushed on the GTN

combesf commented 4 years ago

I updated the CONTRIBUTORS.yaml file

combesf commented 4 years ago

Hello, Thanks @shiltemann for your comments. I update according to your suggestions !

thanks @bebatut for your email

shiltemann commented 4 years ago

Thanks @combesf!

Can I make one small request: could you in the future please refresh your browser window right before making any changes? Otherwise changes others may have made to the file since you last refreshed will be undone again. Thanks!

combesf commented 4 years ago

update done, except for the zenodo links format caus it was already ih this format (@bebatut ?) Thanks a lot

combesf commented 4 years ago

All done (I really think)

combesf commented 4 years ago

Hello @shiltemann @bebatut Just a little ping in case you have time .. I hoped this could be online for the GCC conference next week .. Thanks a lot for your help,
Florence.

shiltemann commented 4 years ago

Hi @combesf thanks for letting us know this is for GCC, we have a lot of open pull requests to review, but will do our best to get around to everybody on time for the conference

combesf commented 4 years ago

hello @shiltemann do you think the tuto can be online soon ? Thanks a lot, Florence.

foellmelanie commented 4 years ago

Hi @combesf

I can review it today.

Best, Melanie

foellmelanie commented 4 years ago

Dear @combesf

I did the tutorial and enjoyed it a lot. Thank you for this nice contribution :)

I have a few suggestions for improving the tutorial. It would be very nice if you could add those.

Thanks again for this wonderful tutorial :) Melanie

combesf commented 4 years ago

Dear @foellmelanie I tried to answer most of your requests / suggestions and hope you will be ok with this version Thanks Florence.

foellmelanie commented 4 years ago

Dear @combesf

thanks a lot for improving the training :)

Before approving it I have a last request, please have a look at my suggestion, I think there was the wrong tool name in the hands on section (1st ID converter tool)?

Cheers, Melanie

combesf commented 4 years ago

Dear @foellmelanie you were right. I just accept your suggestion directly, I hope it is ok cheers and thanks a lot Florence.

shiltemann commented 4 years ago

Hi @combesf I will add a few last changes too. If you want to make any more updates after I (or others) have added changes here, please always make sure to first get the latest version of the files before updating and uploading new ones. Thanks again!

combesf commented 4 years ago

dear @shiltemann I reload pages to be sure to have the latest version. If it is not the case, it is that I do something wrong but I don't know what. @shiltemann @bebatut I created a new zenodo ref with the 3 datasets , and commit it in the md file. hope this is ok now !

shiltemann commented 4 years ago

@combesf no worries, and thanks for the Zenodo link!

shiltemann commented 4 years ago

Hi @combesf the tutorial looks great, thanks :) I made some final tweaks and added some examples for the missing key_points, but I am no expert here, so maybe you can just check them and let me know if you would like to change or add any?

Also, it is always nice to add question boxes inbetween steps so learners can check if they have understood the important points of the analysis, so if you can think of any nice questions that would be great (but we can add those later too)

@foellmelanie maybe you could also have a final look and then feel free to merge whenever you're happy with it :)

combesf commented 4 years ago

@shiltemann @foellmelanie it is ok like this for me, thanks a lot

shiltemann commented 4 years ago

:tada: