Closed lldelisle closed 2 years ago
Questions I have in mind:
heatmap2
tool.Ready for review @hrhotz @bebatut would you mind to check that the changes on strandness are ok for you (if you have time I am also interested in your review for the rest but this is the biggest change I made on what you wrote)?
Thanks @nsoranzo
I am still working on this PR (just the heatmap part because I just updated heatmap2 tool so it can compute the z-score).
Heatmap2 changes done. Waiting for last reviews before changing the workflow.
Thanks a lot @lldelisle for this work. One last things, could you check if the tests for the workflows are still valid?
One last comment. Could you add the level to the metadata? Thanks a lot
Which one would you put? Introductory?
One last comment. Could you add the level to the metadata? Thanks a lot
Which one would you put? Introductory?
I would say intermediate.
I would have said Introductory for the level. We usually use it at the introduction to RNA-Seq analysis
I still need to update the workflow for DEG but I am a bit fighting...
Also what should I do with the tour? How can I test it?
So I guess it can be merged.
Please wait that I update the workflow with tags.
Please wait that I update the workflow with tags.
Ah, ok sorry!
What do we do with the tour? I update it?
@shiltemann @hexylena is it possible to hide the tour so I have time to update it after my course?
I think no worries about the tour. I am quite sure it is a lot out of date. We should probably remove it
Then let's merge like this? Or I remove the tour?
Hi, My last changes are:
Length of the genomic sequence around annotated junctions
to 74 as we explain above that it should be read length - 1. However, the counts in zenodo corresponds to STAR ran with 36 like in PE datasets. What do you think?
ThanksHi there, I am back from holidays and our class is on Wednesday.
Thanks
Let's just remove the tour. I think ok to leave commented out portions.
Thanks @hexylena Ready for review / merge
The updated tutorial is online :tada: I just noticed sth. If nothing is selected for CYOA, then both content is displayed
@hexylena is there a way to select by default one of them?
Yes, that is expected. I'm not sure there's a good solution for that, picking one by default seems sub-optimal, and having both displayed at least the user can see both simultaneously which feels useful? (Espeially when it's e.g. two separate hands-on boxes). Less so when it's really inline stuff.
We could write some JS to select one (randomly or set a default.)
I think we can set a default (at least for this tutorial).
What should the default be?
I prefer STAR but @pavanvidem said in the discussion that FeatureCount was more flexible for non standard gtf... So I would say FeatureCounts, also the end of the tutorial is based on these counts.
@bebatut @gallardoalba @hexylena @nsoranzo @jennaj Thank You very much for all your work and help getting @lldelisle PR into the GTN
Yes, thank you very much, I am really happy that we have an up to date tutorial.
We "just" need now to record a new video for this tutorial :sweat_smile:
two videos! :sob:
Let see if I have time to do this.
This PR in based on #3272 Additional changes in this PR: