galaxyproject / training-material

A collection of Galaxy-related training material
https://training.galaxyproject.org
MIT License
294 stars 846 forks source link

Update ref based rna-seq #3330

Closed lldelisle closed 2 years ago

lldelisle commented 2 years ago

This PR in based on #3272 Additional changes in this PR:

lldelisle commented 2 years ago

Questions I have in mind:

lldelisle commented 2 years ago

Ready for review @hrhotz @bebatut would you mind to check that the changes on strandness are ok for you (if you have time I am also interested in your review for the rest but this is the biggest change I made on what you wrote)?

lldelisle commented 2 years ago

Thanks @nsoranzo

lldelisle commented 2 years ago

I am still working on this PR (just the heatmap part because I just updated heatmap2 tool so it can compute the z-score).

lldelisle commented 2 years ago

Heatmap2 changes done. Waiting for last reviews before changing the workflow.

bebatut commented 2 years ago

Thanks a lot @lldelisle for this work. One last things, could you check if the tests for the workflows are still valid?

lldelisle commented 2 years ago

One last comment. Could you add the level to the metadata? Thanks a lot

Which one would you put? Introductory?

gallardoalba commented 2 years ago

One last comment. Could you add the level to the metadata? Thanks a lot

Which one would you put? Introductory?

I would say intermediate.

bebatut commented 2 years ago

I would have said Introductory for the level. We usually use it at the introduction to RNA-Seq analysis

lldelisle commented 2 years ago

I still need to update the workflow for DEG but I am a bit fighting...

lldelisle commented 2 years ago

Also what should I do with the tour? How can I test it?

gallardoalba commented 2 years ago

So I guess it can be merged.

lldelisle commented 2 years ago

Please wait that I update the workflow with tags.

gallardoalba commented 2 years ago

Please wait that I update the workflow with tags.

Ah, ok sorry!

lldelisle commented 2 years ago

What do we do with the tour? I update it?

lldelisle commented 2 years ago

@shiltemann @hexylena is it possible to hide the tour so I have time to update it after my course?

bebatut commented 2 years ago

I think no worries about the tour. I am quite sure it is a lot out of date. We should probably remove it

lldelisle commented 2 years ago

Then let's merge like this? Or I remove the tour?

lldelisle commented 2 years ago

Hi, My last changes are:

lldelisle commented 2 years ago

Hi there, I am back from holidays and our class is on Wednesday.

  1. Should I remove the tour or I keep like this?
  2. Should I remove the DEXseq part which is commented but out of date?

Thanks

hexylena commented 2 years ago

Let's just remove the tour. I think ok to leave commented out portions.

lldelisle commented 2 years ago

Thanks @hexylena Ready for review / merge

bebatut commented 2 years ago

The updated tutorial is online :tada: I just noticed sth. If nothing is selected for CYOA, then both content is displayed

lldelisle commented 2 years ago

@hexylena is there a way to select by default one of them?

hexylena commented 2 years ago

Yes, that is expected. I'm not sure there's a good solution for that, picking one by default seems sub-optimal, and having both displayed at least the user can see both simultaneously which feels useful? (Espeially when it's e.g. two separate hands-on boxes). Less so when it's really inline stuff.

hexylena commented 2 years ago

We could write some JS to select one (randomly or set a default.)

lldelisle commented 2 years ago

I think we can set a default (at least for this tutorial).

hexylena commented 2 years ago

What should the default be?

lldelisle commented 2 years ago

I prefer STAR but @pavanvidem said in the discussion that FeatureCount was more flexible for non standard gtf... So I would say FeatureCounts, also the end of the tutorial is based on these counts.

hrhotz commented 2 years ago

@bebatut @gallardoalba @hexylena @nsoranzo @jennaj Thank You very much for all your work and help getting @lldelisle PR into the GTN

lldelisle commented 2 years ago

Yes, thank you very much, I am really happy that we have an up to date tutorial.

bebatut commented 2 years ago

We "just" need now to record a new video for this tutorial :sweat_smile:

hexylena commented 2 years ago

two videos! :sob:

lldelisle commented 2 years ago

Let see if I have time to do this.