Closed Marie59 closed 1 year ago
Hi @Marie59! I've added some final tweaks. It looks good to me! I see there are still some TODOs written in there, so just let me know when you are completely ready and I will do final review and merge it :)
@Marie59 it seems there is some TODO on remote sensing tuto notably. Can you look at it and update before asking @shiltemann to review and merge ? Moreover, It would be nice to propose an example datafile as input for the tuto. Don't remember if we were finding a good example data not too big?
@Marie59 it seems there is some TODO on remote sensing tuto notably. Can you look at it and update before asking @shiltemann to review and merge ? Moreover, It would be nice to propose an example datafile as input for the tuto. Don't remember if we were finding a good example data not too big?
I have one or 2 datafiles not that big but still it would take 2 days I think to do the full analysis
Should I open a new PR and close this one ? I don't know how to resolve the conflicts here
I can try to help with that
@Marie59 why does the last commit delete the champs-blocs
directory? I believe this is the main cause of the conflict. Is that tutorial no longer needed or something?
I think there was some commits done on this branch for the champ blocs tutorial which created conflicts afterwards. But the champbloc tuto is already finished and has been push on the training material. So I deleted it thinking it would solve the conflict but apparently not ... sorry
Ahh no worries, that makes it easier to resolve. :)
Just the same workflow issue (the test input missing/creator details.)
I have one or 2 datafiles not that big but still it would take 2 days I think to do the full analysis
I think even that is good, better to have an example dataset than none.
Ooooh could it be finally ready ?! Thank you for all your help @hexylena @shiltemann and @yvanlebras !!
Thanks, it looks good!
Just a question about the time, you said it takes 2 days to complete the tutorial or did I misunderstand? Can we maybe add a warning box to say the analysis will take 2 days so people don't wait around for it? And maybe update it in the time estimate metadata? (it currently says 2 hours).
Which step is it that takes this long? is it possible/would it make sense to provide the outputs from that 2-day step as well (e.g. on Zenodo), so that learners or instructors can continue with the next steps without waiting 2 days?
Yes, of course I will add a warning and change the time. It's one of the last step that takes a lot of time. I can add one of the output to show but the output is not needed for the following steps. So, the users can easily just skip it or continue with the rest.
I still have some picture modification to make I forgot that !
I think it would still be nice to show the output so people can view it without waiting the 2 days, if it's not too much trouble to do that.
I put two photos for it. It's the map biodiversity part is it okay or do we need more ?
I have one last photo too add (I am waiting for the tool to run to put it)
I put two photos for it. It's the map biodiversity part is it okay or do we need more ?
Just whatever you think is needed so that they can evaluate the results of the tool without having to wait the 2 days :) :+1:
perfect, thanks!
Whoo!! Thanks for all your hard work @Marie59! :tada:
Youhou!! Thank you for your help !!
Initiating the PR for the tutorial for conducting a biodiversity study on Sentinel 2 data.