galaxyproject / training-material

A collection of Galaxy-related training material
https://training.galaxyproject.org
MIT License
294 stars 846 forks source link

Add Ocean data view tutorial and new topic #4405

Closed Marie59 closed 5 months ago

Marie59 commented 7 months ago

Thank you for contributing to the GTN! :yellow_heart:

Please check that:

Once these are done, you're ready to go!

Consider sustainable computing with Draft Mode :green_heart: Is your pull request finished? 100% ready to be merged? Or do you want some time to work on it first (which we encourage! It's great to have visibility) If not, then please consider creating this pull request as a draft. Regular pull requests will trigger automated test runs when they are created and every time you update them. As a small contribution to sustainable computing, we skip the most energy intensive of these tests for pull requests marked as drafts. Once your pull request is ready to go, then you can click a button saying "Ready for Review" and the tests will be run!
Marie59 commented 7 months ago

Hi all ! I try to both create a new topic earth system for the trainings and create a tutorial for ODV interactive tool. I think I need to push the Docker on quay.io ? Let me know if I should delete everything because I did a big mess ;)

Marie59 commented 7 months ago

Hi @shiltemann and @hexylena, sorry to bother ! Do you have any ideas what I should do to have the last test working ?

shiltemann commented 7 months ago

@Marie59 the error was unrelated to your changes, I merged in main and that should fix it, let's see :)

Marie59 commented 7 months ago

@Marie59 the error was unrelated to your changes, I merged in master and that should fix it, let's see :)

Great ! Thank you very much !

shiltemann commented 7 months ago

ok, different error now, but progress! :P It is probably missing/wrong metadata somewhere, but can look in more detail for you on Monday.

shiltemann commented 7 months ago

One quick question: are you planning more tutorials for this topic in the near future? (we don't want to get a lot of topics with only a couple of tutorials in them, so if you just didn't know where else to put it, maybe we can think about that, perhaps rename ecology topic to "Ecology and Earth System" orso and putting it there)

oh and no, you don't have to do anything with docker, don't worry :P

bgruening commented 7 months ago

@shiltemann I tried to look at the current topics and see how we can regroup a few things.

What about:

I guess we would need to ask Anne, Peter, Wolfgang and Anton at a first step.

Sequence Analysis looks also like a good candidate to fold into others. 2 of them can go to SARS-CoV2 or OneHealth imho.

Marie59 commented 7 months ago

One quick question: are you planning more tutorials for this topic in the near future? (we don't want to get a lot of topics with only a couple of tutorials in them, so if you just didn't know where else to put it, maybe we can think about that, perhaps rename ecology topic to "Ecology and Earth System" orso and putting it there)

oh and no, you don't have to do anything with docker, don't worry :P

Thanks for your help @shiltemann ! Yes indeed I am planning on getting more tutorials to this topic. I do agree that either mixing this tuto with ecology or climate is a good idea !

shiltemann commented 7 months ago

@bgruening yes, we've been discussing for a while moving some things around, similar to how you suggest, and/or having different "views" in addition to the current topic view, e.g. based on (curated) tags/EDAM terms, etc

@Marie59 in your opinion, would your tutorials fit better with Climate or Ecology? We can update the topic name to make it broader, I just don't have a good sense of where it fits better (@annefou and @yvanlebras please also feel free to share your feelings!)

Marie59 commented 7 months ago

@bgruening yes, we've been discussing for a while moving some things around, similar to how you suggest, and/or having different "views" in addition to the current topic view, e.g. based on (curated) tags/EDAM terms, etc

@Marie59 in your opinion, would your tutorials fit better with Climate or Ecology? We can update the topic name to make it broader, I just don't have a good sense of where it fits better (@annefou and @yvanlebras please also feel free to share your feelings!)

I would say it fits better with climate but really hard to tell (it can fit with both...) maybe @yvanlebras and @annefou can help with this ;)

yvanlebras commented 7 months ago

Hey everyone! Thank you Marie for pushing this! Thank you Helena, Saskia, Björn for your feedback and comments ! It seems to me climate and ecology can keep there own topics as we can imagine a lot of upcoming tutorial in these, and having a earth system one seems to be also relevant I think. In some extent earth system seems to me encompassing biodiversity+ earth surface + atmosphere+ ocean so we can maybe in the future put some ecology or others tuto also in this topic? Having same tutorial displayed in several topics is something ok for you ?

Marie59 commented 7 months ago

Yes I agree with @yvanlebras, thank you ! One other idea I had was to regroup the 3 subjects in one big Ecology, Earth and Climate topic (with another name) and within have subtopics with ecology, climate, ocean, atmosphere, earth surface for instance. I don't know if it's relevant or if it will be too much in one topic.

Marie59 commented 7 months ago

Some more formatting comments, sorry

Nothing to be sorry about ! Thanks a lot for the review I learned a few tips and tricks that will be useful for my future tutorials !!

Marie59 commented 6 months ago

Did we reach a decision concerning the section name ? :)

annefou commented 6 months ago

Yes I agree with @yvanlebras, thank you ! One other idea I had was to regroup the 3 subjects in one big Ecology, Earth and Climate topic (with another name) and within have subtopics with ecology, climate, ocean, atmosphere, earth surface for instance. I don't know if it's relevant or if it will be too much in one topic.

I don't think we have a decision yet. I like the idea of having groups and sub-groups (as suggested above) but I don't think it is possible in Galaxy.

yvanlebras commented 6 months ago

So maybe it is ok to put this tuto as a first tuto for earth system science OR put it in ecology and then, copy/paste / referencing several existing tuto from ecology and climate into the earth system topic ?

hexylena commented 6 months ago

So maybe it is ok to put this tuto as a first tuto for earth system science OR put it in ecology and then, copy/paste / referencing several existing tuto from ecology and climate into the earth system topic ?

the other option of course is the 'synthetic' topics we have like the covid19 one. There's no folder in the GTN named covid19, instead it aggregates all of the tutorials with that tag, and it looks like this: https://training.galaxyproject.org/training-material/topics/covid19/

so you could keep them in their respective ecoloy + climate topics, and then tag them "earth-science" and when there's a few of them, make a synthetic topic like the covid 19 topic.

Marie59 commented 6 months ago

So maybe it is ok to put this tuto as a first tuto for earth system science OR put it in ecology and then, copy/paste / referencing several existing tuto from ecology and climate into the earth system topic ?

the other option of course is the 'synthetic' topics we have like the covid19 one. There's no folder in the GTN named covid19, instead it aggregates all of the tutorials with that tag, and it looks like this: https://training.galaxyproject.org/training-material/topics/covid19/

so you could keep them in their respective ecoloy + climate topics, and then tag them "earth-science" and when there's a few of them, make a synthetic topic like the covid 19 topic.

Hi @hexylena thanks for your answer/solution ! I (and the people of the project too) agree with this possibility ! I will add the right tags. Should I close this PR delete the topic and open a new one with the tutorial in the right topic (I think climate for this one) ?

hexylena commented 6 months ago

@Marie59 please feel free to make the changes directly in this PR if you like :)

Marie59 commented 6 months ago

Not sure what I should do concerning the conflicts ?

Marie59 commented 5 months ago

uh we have a new error that I don't understand.

bgruening commented 5 months ago

I think the funding bodies have been moved to different files. Let's see if this is working.

Marie59 commented 5 months ago

It seems to be searching for an Earth-system.yaml. I don't know why

bgruening commented 5 months ago

Ok, green!

Marie59 commented 5 months ago

Finished ??

bgruening commented 5 months ago

Is it ready from your side?

Marie59 commented 5 months ago

Yes it is ! Youhou!!

bgruening commented 5 months ago

Thanks @Marie59!