NCBI FCS tutorial first commit

galaxyproject / training-material

A collection of Galaxy-related training material

https://training.galaxyproject.org

MIT License

294 stars 842 forks source link

NCBI FCS tutorial first commit #4868

Closed tvedtees closed 2 weeks ago

tvedtees commented 1 month ago

Add NCBI FCS Tutorial

Add short tutorial, workflow, images
Need help with Warning box embedded in "Hands-On Interpreting FCS Output"
Need help with embedded citation Astashya2024 . Does author format need to be changed?

hexylena commented 3 weeks ago

This is shaping up to be a fantastic tutorial, really looking forward to this!!

hexylena commented 2 weeks ago

I have

made some small whitespace changes
cherry-picked in the TRS snippet improvements and made the associated cleanups
improved some alt-text (it wasn't descriptive enough for those using screen readers, for ADA compliance.)

but I think this is now ready to ship!

There are some other features we could take advantage of in the future (i.e. are on the main branch and would require rebasing), e.g. the new workflow preview to avoid the need for a screenshot but, otherwise I think it looks good as-is.

hexylena commented 2 weeks ago

Thanks for all of the patience making our requested changes @tvedtees, they have made for a more FAIR and accessible tutorial!

tvedtees commented 2 weeks ago

@hexylena this looks great overall! I will be going over this again to look for any small enhancements to add.

There are some other features we could take advantage of in the future (i.e. are on the main branch and would require rebasing), e.g. the new workflow preview to avoid the need for a screenshot but, otherwise I think it looks good as-is.

I clicked on the link under the new snippet {% snippet faqs/galaxy/workflows_run_trs.md path="topics/sequence-analysis/tutorials/ncbi-fcs/workflows/NCBI-Foreign-Contamination_Screen.ga" title="NCBI Foreign Contamination Screen Workflow" %} (i.e. Click to Launch NCBI Foreign Contamination Screen Workflow) selected the galaxy server use.galaxy.org, which then redirected to the galaxy instance but had a large error box. Is this expected?

hexylena commented 2 weeks ago

could you share the error box? i see one on EU for a missing tool, but not on .org

tvedtees commented 2 weeks ago

ncbi-fcs-load-workflow-1

ncbi-fcs-load-workflow-2

hexylena commented 2 weeks ago

ah interesting, that was fixed in #4902, not sure, maybe you have a cached copy of the site or so? try force refreshing and the link should work (we've added linting in 4902 to prevent this specific error in the future as well)

tvedtees commented 2 weeks ago

Yes it does work now. Excellent.