galaxyproject / training-material

A collection of Galaxy-related training material
https://training.galaxyproject.org
MIT License
294 stars 842 forks source link

Update tutorial.md to match ENA upload tool wrapper update #4880

Closed B0r1sD closed 1 month ago

B0r1sD commented 1 month ago

based on ena_upload_tool v0.7.1+galaxy1

Still a question about some links in there: The link toolshed.g2.bx.psu.edu/repos/iuc/ena_upload/ena_upload/0.6.1 does not exist. Can it be changed to a link to the latest commit (= tip), a link that does work: https://toolshed.g2.bx.psu.edu/repos/iuc/ena_upload/rev/tip?

Same goes for the link: toolshed.g2.bx.psu.edu/repos/ieguinoa/ena_webin_cli/ena_webin_cli/7d751b5943b0 not working, I think it should be: https://toolshed.g2.bx.psu.edu/repos/ieguinoa/ena_webin_cli/rev/tip.

hexylena commented 1 month ago

Hi @B0r1sD welcome to the GTN!

The link toolshed.g2.bx.psu.edu/repos/iuc/ena_upload/ena_upload/0.6.1 does not exist

Yes, that is expected. It looks like a link, we use the markdown sytnax of a link, but it's actually a tool ID. And inside Galaxy it will be linked to this tool ID.

Unfortunately the toolshed doesn't have a nice api endpoint that shows a tool at a specific version so it does not function as a "real" link.

You've updated them correctly, so, that part is good!

Could you please add yourself to the contributors of this tutorial as well (and add your name in CONTRIBUTORS.yaml in this repo.)

B0r1sD commented 1 month ago

Thank you @hexylena for the information! And I've added my Github name to the contributors.

B0r1sD commented 1 month ago

Hey @hexylena, it seems like it does not recognise my Github username as contributor. Something I can do to change that? It probably has something to do with this being my first contribution so I don't have a page on the GTN yet. I'm also unable to locate the folder that is being referred to by the linting tests (``/training-material/hall-of-fame/B0r1sD/).

hexylena commented 1 month ago

Hi @B0r1sD that's expected if it isn't in CONTRIBUTORS.yaml, please add it here: https://github.com/galaxyproject/training-material/blob/fa4da59af82906fbaa7d9ced2f658824c5a08cc5/CONTRIBUTORS.yaml#L211

hexylena commented 1 month ago

Thanks so much @B0r1sD