new training ewas-suite - please review

galaxyproject / training-material

A collection of Galaxy-related training material

https://training.galaxyproject.org

MIT License

294 stars 846 forks source link

new training ewas-suite - please review #894

Closed poterlowicz-lab closed 5 years ago

poterlowicz-lab commented 5 years ago

hi @bebatut thank you for your comments, I tried to address them, would u be happy to provide approve review for this? Many thanks K

bgruening commented 5 years ago

@kpoterlowicz we also need the tools to be reviewed and published in the main TS before merging I guess.

poterlowicz-lab commented 5 years ago

@bgruening @bebatut, sure we will publish tools in main TS (there are in test TS now). Would u be able to review tools then?

bgruening commented 5 years ago

I will try my best, can we review them before submitting to the MTS?

poterlowicz-lab commented 5 years ago

@bgruening sure please feel free to do it, all tools are in epigenetics category in test TS, thank u for helping

bgruening commented 5 years ago

Is there a github repo or similar, its hard to review on the TTS.

kpbioteam commented 5 years ago

yes, all tools are separate repos on https://github.com/kpbioteam?tab=repositories

kpbioteam commented 5 years ago

Hi @bgruening thank you for your support, would u be able to review tools from there https://github.com/kpbioteam?tab=repositories or should I send you links to separate tools repositories? Please let me know If there is anything which can help you with review.

poterlowicz-lab commented 5 years ago

Hi, it has been a while, I am wondering if I can help in any way to merge this pull request. Apologise but I have a couple of requests from medics when the training for this will be available.

bgruening commented 5 years ago

@kpoterlowicz we are blocked by the tools not available in the MTS. I talked to Kasia offline how to proceed here. In the meantime I have added enable=false to the metadata, which means we can merge this but you only can access the content via the URL not via the website. Is that a compromise until we have reviewed the tools and pushed them to the MTS?

poterlowicz-lab commented 5 years ago

hi @bgruening thank u for a prompt reply. URL will be very helpful.

bebatut commented 5 years ago

I made some formatting changes, fix the slides, and update the data library @kpbioteam and @kpoterlowicz can you check if the changes I made are ok?

After it should be ready to be merged

bgruening commented 5 years ago

@kpoterlowicz @kpbioteam is this ok for you?

kpbioteam commented 5 years ago

@bgruening Sure, thanks for that

bebatut commented 5 years ago

I added you both on the CONTRIBUTORS.yaml file. Can you check the info? Thanks

kpbioteam commented 5 years ago

@bgruening This image is available for public use. We've added source in tutorial.md.

shiltemann commented 5 years ago

Hi @kpoterlowicz I updated this PR, your metadata has been moved to the top of the tutorial.md file now

bebatut commented 5 years ago

Thanks @kpoterlowicz and @kpbioteam You can find your tutorial there: http://training.galaxyproject.org/topics/epigenetics/tutorials/ewas-suite/tutorial.html

poterlowicz-lab commented 5 years ago

Thank you!

From: Bérénice Batut notifications@github.com Sent: 27 August 2018 09:04 To: galaxyproject/training-material Cc: Krzysztof Poterlowicz; Mention Subject: Re: [galaxyproject/training-material] new training ewas-suite - please review (#894)

Merged #894https://github.com/galaxyproject/training-material/pull/894 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/galaxyproject/training-material/pull/894#event-1810005218, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AR2y2BtpfWvP7TyupUkhAP9gHaQTjrNzks5uU6gKgaJpZM4U-F7v.