search

galaxyproject / usegalaxy-playbook

Ansible Playbook for usegalaxy.org
Academic Free License v3.0
30 stars 24 forks source link

Update VCFfilter once new issues with "!=" and "invert" functions are fixed #191

Open jennaj opened 5 years ago

jennaj commented 5 years ago

Ticket at IUC repo: https://github.com/galaxyproject/tools-iuc/issues/2300

Prior fix/update tickets (closed) -- include test history

https://github.com/galaxyproject/usegalaxy-playbook/issues/182#issuecomment-464163384 https://github.com/galaxyproject/tools-iuc/issues/1917 https://github.com/galaxyproject/tools-iuc/issues/1910

VJalili commented 5 years ago

I guess all the issues you've referenced are fixed, shall we close this?

jennaj commented 5 years ago

Did the new test case get added (for an invert query that would fail if not working)? Might just not be linked in. Or ping @jmchilton if you are not sure what that is or why we want to add that.

We can use this other ticket as a tracker for the updated tool install and subsequent testing, once this ticket is closed out (all changes PR'd/done): https://github.com/galaxyproject/usegalaxy-playbook/issues/182

Thanks @VJalili !!

VJalili commented 5 years ago

I added a parameter assertion: https://github.com/galaxyproject/tools-iuc/pull/2385

jennaj commented 5 years ago

@VJalili and I talked. The new PR above is good but not the same as this: https://github.com/galaxyproject/tools-iuc/issues/2386

He will work on that next week. In short, split out the "invert" toggle issue (with a new test case, can address server issues from that) from the expression value issue (now has a test case with related updated help, etc).

Going to leave this open until both have test cases.