galaxyproject / usegalaxy-tools

usegalaxy.* common tools
11 stars 52 forks source link

updating to latest version of ncbi-egapx #834

Closed richard-burhans closed 3 weeks ago

richard-burhans commented 3 weeks ago

TODO: Please replace this header with a description of your pull request.

Installation sequence for tool-installers

richard-burhans commented 3 weeks ago

@galaxybot test this

martenson commented 3 weeks ago

@galaxybot test this

martenson commented 3 weeks ago

shed_tools diff is empty, something is wrong

mvdbeek commented 3 weeks ago

Update without version bump, you can tell by 7c72d5c7e449 being modified, which is not the new revision.

martenson commented 3 weeks ago

except there should be one https://github.com/richard-burhans/galaxytools/commit/f47ba0b127d52901402fe9f830a0095c6f8fa36a

mvdbeek commented 3 weeks ago

https://github.com/richard-burhans/galaxytools/actions/runs/10799704747/job/29956466322

mvdbeek commented 3 weeks ago

(Missing the all_fasta.loc.sample file)

martenson commented 3 weeks ago

the subsequent MTS deploy CI ran fine (https://github.com/richard-burhans/galaxytools/actions/runs/10800498795) and the MTS version on tip bf80a7ed8595 has the increased version and the .loc.sample file

mvdbeek commented 3 weeks ago

The repo files are missing all_fasta.loc.sample, I don't think this can work. I don't know why the tool shed has accepted this ?

martenson commented 3 weeks ago

The tip has the .loc.sample but the previous MTS revision does not, and between those two there is no version bump. So version bump should ideally fix this.

Screenshot 2024-09-11 at 1 11 28 PM

mvdbeek commented 3 weeks ago

I always thought they need to be in the same directory?

martenson commented 3 weeks ago

I don't think that is mandatory or a standard Screenshot 2024-09-11 at 2 55 14 PM

richard-burhans commented 3 weeks ago

FYI: I had accepted a pull request from @fubar2 (Ross Lazarus), but I didn't realize there was a new select param using from_data_table. I never created a tool_data_table_conf.xml.sample file and neither planemo lint nor planemo shed_lint noticed this error. I pushed to my fork, and the github actions were able to push the broken version to the toolshed. I realized this last night and tried pushing out an update with an updated version.

martenson commented 3 weeks ago

@galaxybot test this

martenson commented 3 weeks ago

@galaxybot deploy this