search

galaxyproteomics / tools-galaxyp

Galaxy Tool Shed repositories maintained and developed by the GalaxyP community
MIT License
34 stars 57 forks source link

'mzxml' and 'mzml' filetypes must be specified in lower case #641

Closed eschen42 closed 1 year ago

eschen42 commented 2 years ago

'mzxml' and 'mzml' filetypes must be specified in lower case for inputs to function properly in the workflow editor; I got orange input nodes rather than green when I tried to link an mzxml output to the inputs of maxquant or maxquant_mqpar.

To circumvent this issue, I had to hack the tool xml files in a local Galaxy; then the editor worked, and (luckily) I could upload the workflow to production Galaxies (e.g., UseGalaxy.eu) and they can be run successfully (they can even be edited so long as the connection made in an "offline Galaxy" is not severed). This PR makes the case of the inputs correct, in my view.

Thank you.

attn: @npinter

npinter commented 2 years ago

Thanks. I just changed the labels to restart the test. Looks like the test command failed which has nothing to do with your PR.

bgruening commented 2 years ago

Working on the tests, some fallouts from the Galaxy release yesterday.

bgruening commented 2 years ago

So the test is green, but since the linting is more strict since the new version we have a few lint errors. Does anyone has time to look at those?

eschen42 commented 1 year ago

@bgruening Yes, I will look at it tomorrow