galaxyproteomics / tools-galaxyp

Galaxy Tool Shed repositories maintained and developed by the GalaxyP community
MIT License
34 stars 57 forks source link

eggnog mapper: implement search and annotation phase as additional separate tools #676

Closed bernt-matthias closed 10 months ago

bernt-matthias commented 1 year ago

for rationale see README

TODO:

bgruening commented 1 year ago

Having those 3 steps in one tool is not an option?

bernt-matthias commented 1 year ago

Having those 3 steps in one tool is not an option?

I do not see how to map the steps to different destinations if implemented in one tool (dynamic destinations might be an option, but many sites use static destinations.. Like mine ;))

bernt-matthias commented 1 year ago

Btw. Linting failures are due to the missing updates of the tool-util package for 21.01. Any idea how to get this on the way?

bernt-matthias commented 10 months ago

Having those 3 steps in one tool is not an option?

Let my just add https://github.com/galaxyproteomics/tools-galaxyp/pull/727 to this PR ..

bernt-matthias commented 10 months ago

Let my just add https://github.com/galaxyproteomics/tools-galaxyp/pull/727 to this PR ..

I reconsidered (because --dbmem was already handled here) and just left it as is. I'm happy to change to an entirely admin-controlled behavior, i.e. to use --dbmem only if the admin sets it as in https://github.com/galaxyproteomics/tools-galaxyp/pull/727

bgruening commented 10 months ago

Ship it!