search

galaxyproteomics / tools-galaxyp

Galaxy Tool Shed repositories maintained and developed by the GalaxyP community
MIT License
34 stars 57 forks source link

regex find/replace: use format_source for output #679

Closed jancrichter closed 1 year ago

jancrichter commented 1 year ago

Version 1.0.2 of the tool uses format="input" in its output declaration. This creates an output with data type "input". I figure, the intention is instead to create an output with the same data type as the input. This should fix it, right?

Incidentally, this same error can currently be found in the Tool XML documentation.

bernt-matthias commented 1 year ago

Got it: in the last PR we set a profile. Problem is that format="input" was disabled for non legacy tools (ie tools which specify any profile): https://docs.galaxyproject.org/en/master/dev/schema.html#id1. This was unnoticed because the tests did not include ftype

Using format_source is the correct fix here.