search

galaxyproteomics / tools-galaxyp

Galaxy Tool Shed repositories maintained and developed by the GalaxyP community
MIT License
34 stars 57 forks source link

openms_msfraggeradapter error #740

Open cat-bro opened 4 months ago

cat-bro commented 4 months ago

ping @bernt-matthias

A Galaxy Australia user sent a report of MS Fragger Adapter failing with this stdout

Input file '/home/berntm/Downloads/MSFragger-20171106/MSFragger-20171106.jar' could not be found (by searching on PATH). Either provide a full filepath or fix your PATH environment! Since this file is not strictly required, you might also pass the empty string "" as argument to prevent it's usage (this might limit the usability of the tool).
Error: File not found (the file '/home/berntm/Downloads/MSFragger-20171106/MSFragger-20171106.jar' could not be found)

This looks like a bug but maybe it isn't - is this a path that would exist within a container?

bernt-matthias commented 4 months ago

Jep, bug. Its hardcoded here: https://github.com/galaxyproteomics/tools-galaxyp/blob/3ff8be11f0be7b9ea486577896ded0a806d9d7ee/tools/openms/MSFraggerAdapter.xml#L70

If one wants to use it the best idea would be yo change this to the tool directory and put the jar there.

Better solution is coming in here: https://github.com/bioconda/bioconda-recipes/pull/45127