galehouse5 / skribbl-io-autodraw

Chrome extension that automatically draws images in pictionary game skribbl.io.
https://skribbl.io/
The Unlicense
178 stars 239 forks source link

Colors are bad #7

Closed gellyfisher closed 5 years ago

gellyfisher commented 5 years ago

Green doesn't ever get drawn. Probably some bug in the color distance. I took some code from online and put it together to get a good color distance. see gellyfisher patch 1 branch

timswhatever commented 5 years ago

blue is never drawn either

galehouse5 commented 5 years ago

Thanks, @gellyfisher. I'm having trouble reproducing green not drawing. Can you attach an image that demonstrates the problem?

I'll draw this color gradient in skribbl.io: image

Here is the existing color distance function: image

Here is the color distance function you propose: image

I'm happy to change the color distance function to improve accuracy. I'm having trouble deciding whether the proposed function is an improvement though. Can you help convince me?

galehouse5 commented 5 years ago

@FreePvp, can you attach an image that demonstrates blue not drawing when it should?

timswhatever commented 5 years ago

Also seems like lots of pink, but idk, heres a sans image vs what it draws:

no blue No blue eye

gellyfisher commented 5 years ago

Yeah that and I get this orange instead of green if I use your code (I changed the drawing order though so that it's less messy)

yours

while if I use my code (https://github.com/gellyfisher/skribbl-io-autodraw/blob/master/color-helper.js) then I get

mine
galehouse5 commented 5 years ago

Thanks! I'll investigate further.

timswhatever commented 5 years ago

Yeah that and I get this orange instead of green if I use your code (I changed the drawing order though so that it's less messy)

yours

while if I use my code (https://github.com/gellyfisher/skribbl-io-autodraw/blob/master/color-helper.js) then I get

mine

I tried out your code and get more detailed images, still missing blues. no blue detailed

gellyfisher commented 5 years ago

Its not perfectly blue either in the original. Maybe theres just not a color that's close to its eye color? Maybe try to use something more colorful for testing

galehouse5 commented 5 years ago

Using CIEDE2000 now:

image

image

Light shades of blue resolve to light gray:

image

Not perfect.