galenframework / galen

Layout and functional testing framework for websites
http://galenframework.com
1.41k stars 163 forks source link

Screenshot issue in report on mobile landscape and Chrome emulated devices #432

Open vijkris99 opened 8 years ago

vijkris99 commented 8 years ago

Galen has problems with screenshots in the report if the device orientation is changed from its default value using Appium (For example, running a test on a Samsung Galaxy S4 in Landscape mode - see snapshot below).

mobile landscape issue

Galen has similar screenshot issues running on devices emulated using Chrome browser.

chrome emulation issue

In both cases, the tool itself seems to be working fine, so this is probably just an issue with the report itself. These issues occur irrespective of the specs used or the website tested, so it should be possible to reproduce this fairly easily. Do let me know if you would like more details.

ishubin commented 8 years ago

Thanks for notifying! We used to have similar issues a long time ago. They were related to device pixel ratio and as far as I remember they were fixed. Perhaps this is a regression

vijkris99 commented 8 years ago

Yes, maybe it is a regression defect... It would be great if this could get fixed, considering that Galen's reports are one of the high points of the framework :)

ishubin commented 8 years ago

@vijkris99 Actually I just realized that this might not be an issue of Galen. It seems that Appium gives you incorrect image. For instance on the first photo I clearly see that the phone is in a landscape orientation but Appium provides an image in a weird-state (content is in portrait but image is cropped like it is in landscape). Also on the second image I see that there is a grey area on the image which doesn't make a lot of sense. In Galen we don't have such functionality and we don't fill the rest of the image with grey color.

ankitdadhich commented 5 years ago

@vijkris99 How to launch mobile site while testing with galen? In my current scenario it launches desktop site always.