search

galenframework / galen

Layout and functional testing framework for websites
http://galenframework.com
1.41k stars 163 forks source link

Remove dependency to selenium-edge-driver #515

Open MichaelKunze opened 7 years ago

MichaelKunze commented 7 years ago

For some reasons galen has a dependency to org.seleniumhq.selenium:selenium-edge-driver and no other selenium driver. Why is that? Is that really needed? Can that be removed?

Galen also uses some transitive dependencies from com.codeborne:phantomjsdriver because that one does include all of selenium. Once again. Is that really needed or does galen only use the api?

I'd like to minimize the selenium dependency hell for one. So this might be a start.

Michael

hypery2k commented 7 years ago

the other drivers are included also, see chrome driver. I exclude the selenium reps from phantomjsdriver.

Regarding the driver reps: We could make a smaller lib jar which doesn't have the drivers included. @ishubin What do you think?

MichaelKunze commented 7 years ago

Our grid runs on selenium 3.3. i was told we cannot use selenium 3.5 because of incompatibilities, therefore i can't use the newest galen, which fixes #514 for me. any chance to let the using project provide the drivers needed? galen iteself could depend on selenium-api only (or something)

hypery2k commented 7 years ago

@ishubin what do you think about a core Version?

fhoeben commented 6 years ago

Is there an explicit reason multiple selenium jars are explicitly listed as dependencies? If there would be only one dependency (on selenium-java, which depends on all of the other explicitly depended on .jars) management in projects depending on galen-framework would be easier (e.g. use a newer version of selenium, and exclude the version specified by galen-framework, for instance).