Misleading README regarding CDN and config.js

galetahub / ckeditor

Ckeditor 4.x integration gem for rails

https://ckeditor.com/ckeditor-4/

MIT License

2.23k stars 875 forks source link

Misleading README regarding CDN and config.js #901

Closed StaymanHou closed 3 years ago

StaymanHou commented 3 years ago

After I briefly reviewed the changes made in v5.0, it appears that in README the section regarding CDN and overriding config.js is no longer relevant, as the gem only support loading the editor as well as the config.js via CDN now. Therefore, it's pretty misleading.

StaymanHou commented 3 years ago

Figured that I misunderstood the section in question. Thought that the entire CDN section is optional for setup. Turned out that the include_javascript_tag is required.