search

galetahub / ckeditor

Ckeditor 4.x integration gem for rails
https://ckeditor.com/ckeditor-4/
MIT License
2.23k stars 875 forks source link

Updates ckeditor to 4.17.2 #920

Closed samuelpismel closed 2 years ago

JohnRDOrazio commented 2 years ago

might I suggest to bump to 4.18.0 ? I need a fix from 4.18.0 for a website, and the webmaster uses this gem. I specifically need fix https://github.com/ckeditor/ckeditor4/issues/5044. Seeing it hasn't been merged yet, it should be easy enough to bump to 4.18.0 ...

JohnRDOrazio commented 2 years ago

Hello @samuelpismel , may I ask why you closed the issue as completed? The PR hasn't been merged...

JohnRDOrazio commented 2 years ago

Actually I see that this PR is not needed at all (apart from the fact it was generating an error for undefined constant), to set the ckeditor version you can just set version from cdn in config/initializers/ckeditor.rb

https://github.com/galetahub/ckeditor#load-editor-via-ckeditor-cdn

samuelpismel commented 2 years ago

Hey @JohnRDOrazio , sorry for the late answer.

That was the the reason I closed the PR, it is broken 😕

Sorry for the inconvenience. I'm glad you found a solution for your problem.