search

galetahub / ckeditor

Ckeditor 4.x integration gem for rails
https://ckeditor.com/ckeditor-4/
MIT License
2.22k stars 881 forks source link

How can I save width and height of images uploaded with CarrieWave? #921

Open tmhr94 opened 2 years ago

tmhr94 commented 2 years ago

Hi, there. Thanks for reading.

I've upgraded the gem's version from 4.2.4 to 5.1.1. After upgraded, I found an error undefined method 'extract_dimensions' so I've changed the method to extract_size that solves the error. But I also found an unexpected stuff that is width and height of images uploaded with CarrieWave not saved.

I know this is due to a breaking change at https://github.com/galetahub/ckeditor/commit/e220fc44b75c1a21dd87c8fa98d639a1a3f4a674 .

How can I find another way to save width and height without using extract_dimensions? I'd appreciate it if you could tell me about it.

tmhr94 commented 1 year ago

@galetahub Sorry for the sudden mention to you. I couldn't understand why you have done a commit below. Is there any problem with this codes?? If you can explain about it, would you please tell me reasons?

https://github.com/galetahub/ckeditor/commit/e220fc44b75c1a21dd87c8fa98d639a1a3f4a674