PHP and Galette versions as ARG for dockerfile

grasdk commented 5 months ago

Rather than continously releasing a new Dockerfile with each Galette Release, let the version numbers be ARGs

PHP can have a default varsion if not provided (i.e. 8.2) Galette verison would be required as input for the docker build command.

When doing a new release to trigger the build and publish action, the version of Galette could be extracted from the release TAG.

Some beginning references:

How to use ARG for php-version could be seen here in some of the examples: https://á.se/damp-docker-apache-mariadb-php-fpm/

grasdk commented 3 months ago

PR soon ready to be merged. Waiting for next release.

Have been building two RC using command line args:

galette-1.1.0-rc1-20240508-95bbbc2ede

 docker buildx build --platform linux/amd64 -t galette-local-prerelease \
    --build-arg MAIN_PACKAGE_URL=https://galette.eu/download/dev/ \
    --build-arg GALETTE_RELEASE=galette-1.1.0-rc1-20240508-95bbbc2ede \
    --build-arg PLUGIN_AUTO_VERSION=dev \
    --build-arg PLUGIN_EVENTS_VERSION=dev \
    --build-arg PLUGIN_FULLCARD_VERSION=dev \
    --build-arg PLUGIN_MAPS_VERSION=dev \
    --build-arg PLUGIN_OBJECTSLEND_VERSION=dev \
    --build-arg PLUGIN_PAYPAL_VERSION=dev \
    --load .

galette-1.1.0-rc2-20240518-ed53328d5d:

docker buildx build --platform linux/amd64 -t galette-local-prerelease \
--build-arg MAIN_PACKAGE_URL=https://galette.eu/download/dev/ \
--build-arg GALETTE_RELEASE=galette-1.1.0-rc2-20240518-ed53328d5d \
--build-arg PLUGIN_AUTO_VERSION=dev \
--build-arg PLUGIN_EVENTS_VERSION=dev \
--build-arg PLUGIN_FULLCARD_VERSION=dev \
--build-arg PLUGIN_MAPS_VERSION=dev \
--build-arg PLUGIN_OBJECTSLEND_VERSION=dev \
--build-arg PLUGIN_PAYPAL_VERSION=dev \
--load .

grasdk commented 3 months ago

Closed in https://github.com/galette-community/docker/releases/tag/1.1.0

galette-community / docker

PHP and Galette versions as ARG for dockerfile #21