search

galette-community / docker

Membership management web application towards non profit organizations, in a Docker container !
https://hub.docker.com/repository/docker/galette/galette
GNU General Public License v3.0
5 stars 2 forks source link

Fix vhost #3

Closed Asharas closed 3 years ago

Asharas commented 3 years ago

Hi!

Currently image doesn't make use of the vhost.conf file (not symlinked in ./sites-enabled/).
It causes paths to not be rewritten (eg: http://127.0.0.1/webroot/index.php/login)

This PR fixes that by adding a RUN a2dissite * && a2ensite vhost.conf to the Dockerfile after copying the file. The a2dissite * instruction is to make sure all defaults are disabled.
It also fixes the vhost.conf file.
Result is path correctly rewritten (eg: http://127.0.0.1/login)

Note: There's an error at new install PDF Models init step but it happens on both current and this PR's versions of the image. Trying to determine if present outside of docker context. It doesn't seems to prevent Galette from being usable.

Hiobi commented 3 years ago

Hi @Asharas, this docker image still very a work in progress, like you can see. Thanks for your PR, merged !

Note: There's an error at new install PDF Models init step but it happens on both current and this PR's versions of the image. Trying to determine if present outside of docker context. It doesn't seems to prevent Galette from being usable.

Need to investigate on this partial issue, I agree ! thanks.

Asharas commented 3 years ago

Commenting here since I have nothing worth opening an issue for yet:

Note: There's an error at new install PDF Models init step but it happens on both current and this PR's versions of the image. Trying to determine if present outside of docker context. It doesn't seems to prevent Galette from being usable.

Need to investigate on this partial issue, I agree ! thanks.

I ran some tests with and without a dockerized DB, long story short it happens with mariadb 10.5 (current in Debian repo is 10.3, tested ok with 10.4).
I don't think it's a problem relying on docker context.

trasher commented 3 years ago

I'm currently using mariadb 10.4; and CI is run with mysql 5.7 as far as I've seen. It may be a Galette bug with mariadb 10.5. Do you have any stack trace to provide? (better to report on galette bug tracker https://bugs.galette.eu/projects/galette/ ;))

trasher commented 3 years ago

I'm currently using mariadb 10.4; and CI is run with mysql 5.7 as far as I've seen. It may be a Galette bug with mariadb 10.5. Do you have any stack trace to provide? (better to report on galette bug tracker https://bugs.galette.eu/projects/galette/ ;))

Maybe the simpliest way would be to test that several DB version with github actions; this probably should be done for both mysql and postgres. I won't have time to work on that until a few days, if any of you know how to setup that, a PR would be welcome ;)

Asharas commented 3 years ago

better to report on galette bug tracker https://bugs.galette.eu/projects/galette/ ;)

I was planning on doing that but I won't have time today.

if any of you know how to setup that, a PR would be welcome

I'm not familiar with github actions and I won't have time in the near future to learn it, but if I eventually do I'll try to contribute.

trasher commented 3 years ago

Enhancement of github actions is in progress; see https://github.com/galette/galette/pull/92