search

galexandre / sonar-cobertura

Cobertura plugin for SonarQube
GNU General Public License v3.0
30 stars 26 forks source link

Coverage fails with wrong number of lines #11 #25

Open rohitri-90 opened 6 years ago

rohitri-90 commented 6 years ago

Hi We are facing the issue of sonar coverage failing with wrong line number which is similar to the issue fixed in https://github.com/galexandre/sonar-cobertura/pull/11.But with the recent upgrade of the plugin to version 2.0 the changes are missing which fixed the issue.

ERROR: Error during Sonar runner execution ERROR: Unable to execute Sonar ERROR: Caused by: Line 39 is out of range in the file cbc-mimir-np-inventory/src/main/java/com/services/business/config/FeignClientConfiguration.java (lines: 30) ERROR:

We think sonar analysis should not fail in case of code coverage even if there are some mismatch of line numbers for some file.

Regards Rohit

rohitri-90 commented 6 years ago

Hi Geoffrey I have already fixed the issue in https://github.com/galexandre/sonar-cobertura/pull/11 and have again done the fix for the latest plugin version(2.0).Please let me know if you are going to merge the same code from old PR or shall i submit a new PR for the same and please also let me know which branch shall i submit the pull request .

Regards Rohit

galexandre commented 5 years ago

Hi @rohitri-90,

Sorry for the delay of my answer. I will have a look at the PR you have opened and apply the changes.

Regards,

Geoffrey