Updating to SQ 5.6 / SJava 4.0

galexandre / sonar-cobertura

Cobertura plugin for SonarQube

GNU General Public License v3.0

30 stars 26 forks source link

Updating to SQ 5.6 / SJava 4.0 #6

Closed bguerin closed 8 years ago

bguerin commented 8 years ago

Fix #5

m-g-sonar commented 8 years ago

Hey, thanks for your contribution!

in order to have the ITs passing, you should change the travis.yml file at the root folder to modify version of Java (from 7 to 8), as well as version of SQ.

The plugin currently doesn't have a community maintainer. Would you be interested? (Requires max 1 or 2 release/year)

bguerin commented 8 years ago

@m-g-sonar I made change in .travis.yml, but build is still failling, I guess because .m2 cache is not up to date ... How can I fix this ? (if I am able to ...)

For being a maintainer, I am just a user of SonarQube, not a plugin developer, I know nothing about SonarQube code, nor its plugins ecosystem ...

m-g-sonar commented 8 years ago

Okay @bguerin, I'll have a look!

About being maintainer, no worries, I was just asking! :)

m-g-sonar commented 8 years ago

@bguerin: I investigate the issue on travis. There is still 2 things to be fixed:

In order to have the IT not failing because of its size, it has to be run in batch mode. To do so, simply add -B or --batch-mode in the travis.sh file, in the line running the IT: https://github.com/SonarQubeCommunity/sonar-cobertura/blob/master/travis.sh#L23
After fixing that, another issue is going to appear, related to the fact that the Cobertura plugin now needs to provide common-io and common-lang.

I'll let you fix your PR accordingly.

bguerin commented 8 years ago

@m-g-sonar : thanks for these informations ! I will update my PR soon

bguerin commented 8 years ago

CI fixed, many thanks for your help and your time !

ceagan commented 8 years ago

I tested this fix on our Sonar installation and I can confirm that it is working for us now. Thanks!

m-g-sonar commented 8 years ago

Okay, I'm going to merge your PR, and start a RFF (Request For Feedback) thread for a new release. Thanks for the fix.

Finally, please note that next release will have to be made by the community, as Sonarsource is not maintaining this plugin anymore.

m-g-sonar commented 8 years ago

RFF for version 1.7 has started on this thread: https://groups.google.com/d/topic/sonarqube/AGGQJLa1KZA/discussion