search

galexrt / dellhw_exporter

Prometheus exporter for Dell Hardware components using Dell OMSA.
https://dellhw-exporter.galexrt.moe
Apache License 2.0
119 stars 41 forks source link

Minor trouble with updated build routines (promu-related) #42

Closed sfudeus closed 4 years ago

sfudeus commented 4 years ago

Hi Alex,

while trying to use your updated build setup with promu I stumbled over some minor issues which break our builds.

a) promu is referenced as $(PROMU) in the Makefile, which is only set to promu, assuming that it lives in the path. I suggest to use either the location where you put it ($(FIRST_GOPATH)/bin/promu) or set that as variable PROMU

b) Makefile assumes PREFIX being set when calling promu --prefix $(PREFIX), but PREFIX might not be set. I suggest to add --prefix $(PREFIX) only when PREFIX is set.

Cheers, Stephan

galexrt commented 4 years ago

@sfudeus Hi Stephan,

  1. Yeah, makes sense. I have switched it to use the downloaded promu binary path.
  2. The CWD variable should have been used there, instead of the PREFIX.

Will push a new release in a bit that includes those fixes. v1.5.17 has been pushed and is currently being built.

Please let me know if the latest commit resolves the issues found.

Edit: Seems that the GitHub CI doesn't like these changes, I'm looking into and try to check the issue on RC tags v1.5.18-rc.... v1.5.19 fixed the CI issues.

sfudeus commented 4 years ago

thx, looks good so far