search

galexrt / dellhw_exporter

Prometheus exporter for Dell Hardware components using Dell OMSA.
https://dellhw-exporter.galexrt.moe
Apache License 2.0
116 stars 41 forks source link

Add support for firmware versions #44

Closed sfudeus closed 4 years ago

sfudeus commented 4 years ago

This PR adds support for #43, adding a "firmwares" collector which provides 2 additional metrics for bios, idrac and lifecycle_controller version as labels. The metric values are always 0, only the labels of the metrics transport the info.

I was unsure if those metrics maybe should be added to one of the existing collector (e.g. chassis), please comment on those, I can still move it around. At this place, we could add more metrics if more versions come available in omreport which are yet missing (nic, backplane, raid, ...)

galexrt commented 4 years ago

A quick test on my old trusty Dell Poweredge 2950 confirms the changes are working :+1: 

# HELP dell_hw_bios Version info of firmwares/bios.
# TYPE dell_hw_bios gauge
dell_hw_bios{manufacturer="dell inc.",release_date="10/30/2010",version="2.7.0"} 0
[...]
# HELP dell_hw_firmware Version info of firmwares/bios.
# TYPE dell_hw_firmware gauge
dell_hw_firmware{baseboard_management_controller="2.50.00.00 (build 0)",remote_access_controller_firmware="1.60.00 (build 17)"} 0
[...]

Naming wise I think they should be fine.

galexrt commented 4 years ago

A new minor release, containing these changes (and some smaller fixes I pushed in the meantime), will be published in the next 15-30 minutes.

sfudeus commented 4 years ago

now that was fast :-) thx