search

galexrt / dellhw_exporter

Prometheus exporter for Dell Hardware components using Dell OMSA.
https://dellhw-exporter.galexrt.moe
Apache License 2.0
119 stars 41 forks source link

Windows omreport defaults #47

Closed kyle-williams-1 closed 4 years ago

kyle-williams-1 commented 4 years ago

This sets the correct default omreport binary path when using Windows or Linux.

galexrt commented 4 years ago

@kyle-williams-1 Any reason you closed the PR? Code wise it looks fine, I don't have a Windows system to verify this on, but if it works on your Windows machines.

kyle-williams-1 commented 4 years ago

@galexrt, Just re-opened! I ran on a Windows system and it's working great.

galexrt commented 4 years ago

I'll push a new release when #46 has been merged or at latest on the weekend.

galexrt commented 4 years ago

@kyle-williams-1 Which Windows "platform" are you on? I would like to look into enabling release binaries for Windows.

The build tool (promu) that is used has windows/amd64 and windows/i386 available, should both be enabled?

kyle-williams-1 commented 4 years ago

@galexrt I have only tested windows/amd64, but I think just amd64 would be useful at this time.

galexrt commented 4 years ago

@kyle-williams-1 Got it. I'll enable additional windows/amd64 builds for the next releases.