search

galexrt / dellhw_exporter

Prometheus exporter for Dell Hardware components using Dell OMSA.
https://dellhw-exporter.galexrt.moe
Apache License 2.0
116 stars 41 forks source link

Windows Service Support #54

Closed kyle-williams-1 closed 4 years ago

kyle-williams-1 commented 4 years ago

This adds a pretty simplistic implementation of https://github.com/kardianos/service, so that we can implement the right events and signals required for a binary to be used in a Windows service. This does not implement the actual installation/removal of services. It simply implements the ability to daemonize the process for Windows use. This shouldn't change Linux implementation, and the testing I've done locally appears to be consistent.

I'd appreciate any additional checkout/verification you could do as well.

poblahblahblah commented 4 years ago

I can confirm that this builds and runs cleanly on both OSX and Linux.

galexrt commented 4 years ago

@kyle-williams-1 I think it would be good to add these "Windows Service" to a new installation instructions doc page.

There is no "Installation" doc page, but with this PR creating the initial page with Windows Service installation instructions, I'll gladly look into adding Linux instructions for Docker and systemd service.

Please let me know what you think.

kyle-williams-1 commented 4 years ago

@kyle-williams-1 I think it would be good to add these "Windows Service" to a new installation instructions doc page.

There is no "Installation" doc page, but with this PR creating the initial page with Windows Service installation instructions, I'll gladly look into adding Linux instructions for Docker and systemd service.

Please let me know what you think.

Added. Let me know if you think it needs any updates.

galexrt commented 4 years ago

Thanks for the PR!

I'll get on adding the Installation instructions docs for Linux and / or Docker soon.