search

galexrt / extended-ceph-exporter

A Prometheus exporter to provide "extended" metrics about a Ceph cluster's running components (e.g., RGW).
Apache License 2.0
6 stars 2 forks source link

Fix template deployment.yaml resources #3

Closed bumarcell closed 3 months ago

bumarcell commented 3 months ago

The current deployment.yaml has temlated resources using with which changes the context. Inside the new context .Values.resources is used, which doesn't exist in that context, causing the chart to fail. volumeMounts for example is templated correctly.

galexrt commented 3 months ago

Thanks for the PR!

Could you please add helm: to your commit messages so that the commit lint is going to be happy and if possible run make helm-docs to generate the updated helm chart docs.

bumarcell commented 3 months ago

Thanks for the info @galexrt I hope it works now?

galexrt commented 3 months ago

@bumarcell For the new commit, yes. Your previous two commits would need to be adjusted to that "format" as well.

E.g., this guide can help you to change the first two commits via git cli https://www.baeldung.com/ops/git-commit-message-changes#reword-an-older-commit-message

bumarcell commented 3 months ago

done

galexrt commented 3 months ago

Thank you very much!

bumarcell commented 3 months ago

Happy to help. Thank you as well for your work! ❤️