Fix secret template - Githubissues

galexrt / extended-ceph-exporter

A Prometheus exporter to provide "extended" metrics about a Ceph cluster's running components (e.g., RGW).

Apache License 2.0

6 stars 2 forks source link

Fix secret template #4

Closed bumarcell closed 3 months ago

galexrt commented 3 months ago

Thanks!

StopMotionCuber commented 2 months ago

This is referencing Values.config.rgw.multiMode.enabled. However, in the README.md multiMode is placed at Values.config.multiMode.enabled, missing the rgw key in the middle. Therefore this chart fails to deploy with default settings. Would be great if this could be fixed at either place

bumarcell commented 2 months ago

@StopMotionCuber You are right. There’s an error in the default values, which makes it’s way to the auto-generated documentation. The templates however all reference ‘config.rgw.multiMode’

Another note is that the templating fails if you define ‘rgw.multiMode.enabled’ as bool. Currently it has to be quoted because it will be passed to b64 func inside the secret.

galexrt commented 2 months ago

@StopMotionCuber @bumarcell I have pushed a commit which should hopefully address both issues (chart version will be 1.5.0):

Switched config.rgw.multiMode to config.multiMode
Fix config.multiMode.enabled not being able to be a boolean.

Please let me know if that fixes the mentioned issues. :smiley:

bumarcell commented 2 months ago

@galexrt I would actually keep multiMode inside rgw 😄 it makes sense to me at least. Another thing that caused me a problem was env template in the deployment; I had to set .Values.config.rgw.existingSecret.name=nil although I'm not using an existing secret for one rgw but rather a realms.yaml file for multiple ones.

StopMotionCuber commented 2 months ago

This works for me with default settings, thanks for the quick fix