galexrt / presentation-gitlab-k8s

These are the example files for my presentation and blog post about GitLab + Kubernetes for Continuous Delivery.
https://edenmal.moe/post/2019/GitLab-Kubernetes-Using-GitLab-CIs-Kubernetes-Cluster-feature/
MIT License
166 stars 132 forks source link

"This isn't the best way" #1

Closed snorfalorpagus closed 4 years ago

snorfalorpagus commented 4 years ago

Thanks for making this available. In the README it says:

INFO This isn't the best way to deploy application Docker images to K8s, this is more of an example how simple it can be.

Is there a discussion somewhere on the limitations of the approach taken? Why isn't it the best?

galexrt commented 4 years ago

Limitations of this repo / example:

These are the ones that come to my mind besides, that some code / manifests parts are feeling a bit rought ("style wise").

There isn't / wasn't really a discussion going on, but feel free to discuss here.

snorfalorpagus commented 4 years ago

Thanks! That's helpful.