gali8 / Tesseract-OCR-iOS

Tesseract OCR iOS is a Framework for iOS7+, compiled also for armv7s and arm64.
http://www.nexor.it
MIT License
4.22k stars 949 forks source link

More unit tests #133

Closed ws233 closed 9 years ago

ws233 commented 9 years ago
  1. no more readwrite absoluteDataPath property.
  2. Test for version
  3. Test for initWithLanguage:engineMode
  4. Tests for configEngine
  5. Tests for resetEngine
coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.47%) when pulling 7ef8021672c7957d995cd4e340dc8136072895e6 on ws233:master into 551238a6cdb258a9b70db23f240debf1c9951f08 on gali8:master.

kevincon commented 9 years ago

Thanks for adding these tests! Do you want me to merge and close this now or leave it open? Do you want to add any more tests?

ws233 commented 9 years ago

I'm in progress with some more tests. But I think it's better to spread them to different small commits. Otherwise it will be to big and diffucalt to understand.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+2.64%) when pulling 96bb45827cfac5af65ae75fa1d9b86c38022dc79 on ws233:master into 551238a6cdb258a9b70db23f240debf1c9951f08 on gali8:master.

ws233 commented 9 years ago

That's enough so far.

ws233 commented 9 years ago

Done. You should also be aware, that G8Tesseract initializer will now return nil, if it's called with cashes related datapath and there is niegther tessdata folder in the Cashes directory nor App bundle. That means it first tries to copy tessdata from the App bundle to Caches folder and start from there, if there is no tessdata folder yet. In the case there is also no tessdata in the App bundle it cannot copy anything and cannot start successfully. Therefore returns nil.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+2.64%) when pulling 30c2e87868479bcacdf7a1229edec80de20be03b on ws233:master into 551238a6cdb258a9b70db23f240debf1c9951f08 on gali8:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+2.64%) when pulling 30c2e87868479bcacdf7a1229edec80de20be03b on ws233:master into 551238a6cdb258a9b70db23f240debf1c9951f08 on gali8:master.

kevincon commented 9 years ago

Sounds good, thanks again for these contributions! Merging and closing.