search

gali8 / Tesseract-OCR-iOS

Tesseract OCR iOS is a Framework for iOS7+, compiled also for armv7s and arm64.
http://www.nexor.it
MIT License
4.22k stars 949 forks source link

Automatically call + (void)clearCache on memory warning #119 #134

Closed ws233 closed 9 years ago

ws233 commented 9 years ago
  1. clearCache is now called right after memory warning notification has been send. A note about this is added to the .h
  2. Tests are added. 2.1 checking that clearCache calls are safe, while there is a recognition is in process. A note about this is also added to .h 2.2 checking that clearCache is automatically called on UIApplicationDidReceiveMemoryWarningNotification
ws233 commented 9 years ago

By the way. Why there is no more unit testing applied? What's wrong?

ws233 commented 9 years ago

Wow! This time the tests started. It's strange...

coveralls commented 9 years ago

Coverage Status

Coverage increased (+3.11%) when pulling fc0efa75769ad08954d52933a63a5a16e4077044 on ws233:master into b9027032ae4f7efeca1eb4dc91a08c2e7acae46f on gali8:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+3.14%) when pulling 0b307bd5bcdeb873de093e93c97847b6e1f99db5 on ws233:master into b9027032ae4f7efeca1eb4dc91a08c2e7acae46f on gali8:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+3.14%) when pulling 0b307bd5bcdeb873de093e93c97847b6e1f99db5 on ws233:master into b9027032ae4f7efeca1eb4dc91a08c2e7acae46f on gali8:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+3.14%) when pulling f1c994863985e58785941c340fa701582429fdc2 on ws233:master into b9027032ae4f7efeca1eb4dc91a08c2e7acae46f on gali8:master.

kevincon commented 9 years ago

Looks good! Any other concerns before I merge it?

coveralls commented 9 years ago

Coverage Status

Coverage increased (+3.11%) when pulling 204c57f9dd883afbecbff851e8675ee76732fb06 on ws233:master into b9027032ae4f7efeca1eb4dc91a08c2e7acae46f on gali8:master.

ws233 commented 9 years ago

That PR seems to satisfy all of us :) It doesn't have eigther setters and getters in the initializaer or @synthesize. It also doesn't have uncoverred line related to absoluteDataPath.

@BamX, could you take a look?

bamx23 commented 9 years ago

Looks good!

ws233 commented 9 years ago

Let's merge! :)

ws233 commented 9 years ago

But before we merge ^.^ there is a commit removing those warnings we already had removed once before :)

ws233 commented 9 years ago

And one warning from the unit tests about the same as well.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+3.11%) when pulling 1d59aafdf62bc41a978d7a032aa53f04d2a4559e on ws233:master into b9027032ae4f7efeca1eb4dc91a08c2e7acae46f on gali8:master.

kevincon commented 9 years ago

Looks good! I'll merge and close it now.