search

gali8 / Tesseract-OCR-iOS

Tesseract OCR iOS is a Framework for iOS7+, compiled also for armv7s and arm64.
http://www.nexor.it
MIT License
4.22k stars 949 forks source link

Missing 'preprocessedImageForTesseract:sourceImage:' delegate forwarding #190

Closed mgratzer closed 9 years ago

kevincon commented 9 years ago

Thanks for this pull request! Since our unit tests didn't catch that the delegate function was missing in G8RecognitionOperation, could you also add a unit test that covers this?

mgratzer commented 9 years ago

I adopted the existing approach checking for the operation callback blocks and added assertions for all forwarded callbacks using the delegate pattern inside G8RecognitionTestsHelper.

ws233 commented 9 years ago

@kevincon, we have lost test coverage badge for every PR? I don't see them anymore.

kevincon commented 9 years ago

@mgratzer Thanks so much! Merging and closing now...

@ws233 I'm not sure, I think @gali8 might need to re-authorize coveralls or double-check the repo's settings at coveralls.io. I'll create a new issue for this task for him.

ws233 commented 9 years ago

There was 1 uncovered line in this patch.

@mgratzer, since we are trying to achive 100% code test coverage, Could you add tests to cover that 1 missed line from your patch?