search

gali8 / Tesseract-OCR-iOS

Tesseract OCR iOS is a Framework for iOS7+, compiled also for armv7s and arm64.
http://www.nexor.it
MIT License
4.22k stars 949 forks source link

Podspec source doesn't reference tag; also, tag version 5.0.1 #395

Open UberJason opened 5 years ago

UberJason commented 5 years ago

Hi there! I noticed your Podspec file only points its s.source to the Tesseract-OCR-iOS GitHub repository directly, which means when people install, they're just getting the latest commit on the master branch. Most Podspec files specify both a :git and a :tag to align Pod versions with GitHub tags/releases, e.g.:

s.source           = {
    :git => "https://github.com/onmyway133/Anchors.git",
    :tag => s.version.to_s
  }

May I suggest that you update your Podspec file to include this :tag => s.version.to_s line, and also tag commit 5d1918e with version 5.0.1 to keep everything clean and up-to-date?

xmollv commented 5 years ago

I was about to open the same issue. As @UberJason says, it would be lovely if the 5.0.1 release was correctly tagged to properly specify the version in a Podfile.