galister / wlx-overlay-s

Access your Wayland/X11 desktop from Monado/WiVRn/SteamVR. Now with Vulkan!
GNU General Public License v3.0
100 stars 18 forks source link

Update Dependencies #48

Closed HavenOfTheRaven closed 3 weeks ago

HavenOfTheRaven commented 3 weeks ago

I updated dependencies to their latest versions while testing to ensure that nothing broke. I was unable to update three packages due to compilation errors, those being: openxr 0.17.1 -> 0.18.0 ash 0.37.3 -> 0.38.0 vulkano 94f50f1 -> b9f3e89

galister commented 3 weeks ago

Please keep ash as is, we need the same version that vulkano pulls in.

HavenOfTheRaven commented 3 weeks ago

Please keep ash as is, we need the same version that vulkano pulls in.

Vulkano at 94f50f1 uses ash 0.37.3, if you would like I can revert ash to 0.37.2 in Cargo.toml?

galister commented 3 weeks ago

oh nvm then, thanks

HavenOfTheRaven commented 3 weeks ago

Would you like me to fix the compilation errors on vulkano and ash so we can update them?

HavenOfTheRaven commented 3 weeks ago

I decided to take a look at the errors and was easily able to fix them for the new ash and vulkano versions. I then did some testing to confirm everything still worked fine. Currently the only dependency at an earlier version is openxr.

HavenOfTheRaven commented 3 weeks ago

openxr cannot be updated to 0.18.0 since it removes the extx_overlay ExtensionSet, this was added back in with a later commit. Just to clarify ash being updated to 0.38.0 does not create a conflict with Vulkano since Vulkano at b9f3e89 uses ash 0.38.0 as well.

galister commented 3 weeks ago

thanks!

HavenOfTheRaven commented 3 weeks ago

THANK YOU this is one of my first pull requests