Closed richard-kurtosys closed 6 years ago
The build error seems to be an issue unrelated to what I am trying to PR:
/Users/travis/.node-gyp/0.12.18/include/node/v8.h:5800:54: error: 'CreateHandle' is a protected member of 'v8::HandleScope'
return Handle<T>(reinterpret_cast<T*>(HandleScope::CreateHandle(
How can this be resolved?
not gonna merge it. dont want to lower the buffer size. should fix the read stream you are using to read only the eligible count of bytes. it reads inAmount when it should limit the read data by the read data size.
k. so:
Gal.
When using two streams as inputs, a 10Mb buffer is used to store the input stream. The output stream is then created from this which results in a 200k input being converted to a 10Mb output. While reducing the size of the buffer may cause the buffer to be reused more often, the output size is closer to the input size. Some benchmarks are available here: https://github.com/galkahana/HummusJS/issues/247