search

galkahana / HummusJS

Node.js module for high performance creation, modification and parsing of PDF files and streams
http://www.pdfhummus.com
Other
1.15k stars 169 forks source link

Pre-built binaries for Windows and Electron 2.0.2 #294

Closed simone closed 6 years ago

simone commented 6 years ago

Hi, first of all thank for your library, it's veri useful. I would ask you to upload on S3 the prebuilt for windows of electron 2.0.2.

I'm reading you can use AppVeyor or Travis to make the task in CI.

Let me know if you need help

hhaidar commented 6 years ago

+1

hhaidar commented 6 years ago

I've added builds for electron 1.8 and 2 in #313.

@galkahana please let me know if there's anything else I should do.

galkahana commented 6 years ago

ok. so we got electron now. windows is still a TODO

hhaidar commented 6 years ago

via #316, thanks again @galkahana

galkahana commented 6 years ago

@hhaidar thank you for your PR :)

ok, we should have windows now too.

simone commented 6 years ago

Cool, works perfectly with electron-builder also from my mac osx. Many thanks. $ npm run build:prod && npx electron-builder build --windows • electron-builder version=20.28.2 • loaded configuration file=app/electron-builder.json • writing effective config file=app-builds/builder-effective-config.yaml • rebuilding native production dependencies platform=win32 arch=x64 • packaging platform=win32 arch=x64 electron=2.0.7 appOutDir=app-builds/win-unpacked • building target=portable file=app-builds/app.exe archs=x64

deps: "hummus": "1.0.90",

devDeps: "electron": "2.0.7", "electron-builder": "20.28.2",

hhaidar commented 6 years ago

@simone are you having any issues getting electron-builder to download the correct binaries for cross-platform builds? For example, building for Linux on OSX?

simone commented 6 years ago

Let me check... No, the Linux build don' seem to work from OSX.