search

galkahana / HummusJS

Node.js module for high performance creation, modification and parsing of PDF files and streams
http://www.pdfhummus.com
Other
1.14k stars 169 forks source link

Add electron to builds #313

Closed hhaidar closed 5 years ago

hhaidar commented 5 years ago

I tried my best.

Ref #294

galkahana commented 5 years ago

k. that doesn't really work. i mean compiling seems to happen, but seems like with publishing it doesn't work. try to figure out how node-pre-gyp/travis should work with electron and let's try again

galkahana commented 5 years ago

this build is for reference: https://travis-ci.org/galkahana/HummusJS/builds/417938173

when i tried to use it with publish binary

galkahana commented 5 years ago

im also trying to figure it out myself. i guess its just a matter of publishing with the same flags as building, but i need to read node-pre-gyp to be sure.

hhaidar commented 5 years ago

I think we can accomplish that by setting a few env vars:

- if [[ $ELECTRON_VERSION ]]; then
  export npm_config_target=$ELECTRON_VERSION;
  export npm_config_target_arch=x64;
  export npm_config_disturl=https://atom.io/download/electron;
  export npm_config_runtime=electron;
  fi

I'm trying that out locally.

hhaidar commented 5 years ago

This should do it: #316

galkahana commented 5 years ago

k. binaries are up. wanna give it a spin?

hhaidar commented 5 years ago

👍 👍 👍